Skip to content

[Backport] Fixing Snake Case To Camel Case#18425

Merged
magento-engcom-team merged 2 commits intomagento:2.2-developfrom
lewisvoncken:2.2-develop-PR-port-18064
Oct 9, 2018
Merged

[Backport] Fixing Snake Case To Camel Case#18425
magento-engcom-team merged 2 commits intomagento:2.2-developfrom
lewisvoncken:2.2-develop-PR-port-18064

Conversation

@lewisvoncken
Copy link
Copy Markdown
Contributor

@lewisvoncken lewisvoncken commented Oct 6, 2018 •
edited by josefbehr
Loading

Original Pull Request

#18064

Description

Refactoring SimpleDataObjectConverter class
and updated code where you can use SimpleDataObjectConverter

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: Experius partners-contribution Pull Request is created by Magento Partner Component: Framework/App Component: Framework/Api USE ONLY for FRAMEWORK RELATED BUG! E.g If bug related to Catalog Service Contracts use just Catalog Component: Signifyd Component: Webapi Use with concrete module component label E.g. "Component: Webapi" + "Catalog" Release Line: 2.2 labels Oct 6, 2018
@josefbehr josefbehr self-assigned this Oct 7, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Oct 7, 2018
@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Oct 7, 2018

Hi @josefbehr, thank you for the review.
ENGCOM-3114 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit bc775a5 into magento:2.2-develop Oct 9, 2018
magento-engcom-team pushed a commit that referenced this pull request Oct 9, 2018
ENGCOM-3114: [Backport] Fixing Snake Case To Camel Case #18425
ed2a41b
@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Oct 9, 2018

Hi @lewisvoncken. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@josefbehr josefbehr josefbehr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@josefbehr josefbehr

Labels

Component: Framework/Api USE ONLY for FRAMEWORK RELATED BUG! E.g If bug related to Catalog Service Contracts use just Catalog Component: Framework/App Component: Signifyd Component: Webapi Use with concrete module component label E.g. "Component: Webapi" + "Catalog" Event: squashtoberfest Partner: Experius partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2

Projects

None yet

Milestone

Release: 2.2.8

Development

Successfully merging this pull request may close these issues.

6 participants

@lewisvoncken @magento-engcom-team @josefbehr @sidolov @hryvinskyi @ishakhsuvarov